Skip to content

Conversation

@entrpn
Copy link
Contributor

@entrpn entrpn commented Sep 16, 2024

What does this PR do?

Fixes step time calculations for ptxla training script.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@entrpn
Copy link
Contributor Author

entrpn commented Sep 17, 2024

@sayakpaul please help me review. I fixed the per step time calculations which were wrong previously. Thanks!

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left a comment.

Comment on lines -8 to -16
where we shard the input batches over the TPU devices.

As of 9-11-2024, these are some expected step times.

| accelerator | global batch size | step time (seconds) |
| ----------- | ----------------- | --------- |
| v5p-128 | 1024 | 0.245 |
| v5p-256 | 2048 | 0.234 |
| v5p-512 | 4096 | 0.2498 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the corrected numbers instead of deleting the table?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will take some time to collect these. Can we push these changes for now with an action item to add this table in the future?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't prefer that. Since we already had these values and communicated about it, I would prefer if the PR indicated the changes. Cc: @tengomucho as well.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Oct 17, 2024
@entrpn
Copy link
Contributor Author

entrpn commented Oct 17, 2024

@sayakpaul I'm still working on this.

@sayakpaul sayakpaul removed the stale Issues that haven't received updates label Oct 18, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@entrpn entrpn closed this Nov 4, 2024
@entrpn entrpn mentioned this pull request Nov 4, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants